[SFLphone] sflPhone 0.9.6 - several source rpm build problems

[René Krell]

Hello,

sflPhone looks very good and I already asked the openSUSE people to integrate
it into their distribution. There is a few things I like to tell you with the
source rpm you provide.

At the moment, I use openSUSE 11.2 Milestone 5 on a 64 bit platform (but this
doesn't matter so much, 11.1 would do the same I guess). During rebuilding
http://rpm.sflphone.org/sflphone-common-0.9.6-opensuse.src.rpm
I run into several problems, which require patches. I wonder how you could
compile that source rpm at all.

Platform-independent:

PROBLEM 1:
-----------------------------------------------------------
...
g722.cpp: In member function ‘int G722::g722_encode(int*, const int16_t*, int)’:                                                                            
g722.cpp:770: error: ‘uint8_t’ was not declared in this scope                                                                                               
g722.cpp:775: error: ‘uint8_t’ was not declared in this scope
g722.cpp:775: error: expected ‘;’ before ‘code’
make[4]: *** [libcodec_g722_so-g722.o] Error 1
...
-----------------------------------------------------------

SOLUTION
See: http://lists.savoirfairelinux.net/pipermail/sflphone/attachments/20090726/d8a77fd4/attachment.obj


PROBLEM 2:
Double copy of debug.h in libs/dbus-c++/src/Makefile

SOLUTION:
libs/dbus-c++/src/Makefile.am:
Remove line 29:
-	$(HEADER_DIR)/debug.h \
(it is twice there).



Platform-specific:

PROBLEM 3:
There is a problem with the %install% section in the rpm spec file on 64 bit
systems. Somewhere in your build files is a hardcoded target directory "lib",
which must be in case of 64 bit systems "lib64". Thus, this occurs only on
compiling on x86_64 platforms.
At the moment, the local installation section in the spec file fails with
something like ".../usr/local/lib/... should be under */lib64".

SOLUTION:
Best solution not known at the moment to me, but the target lib dir should be
flexible, anyway. Maybe there are there are affected more files, not only the
spec file.
See also this one:
http://forums.opensuse.org/opensuse-build-service-obs/396696-_libdir-doesnt-exapnd-lib64.html
http://osdir.com/ml/linux.redhat.rpm.devel/2006-09/msg00066.html

René